Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIG-1267: Making the template even more fulsome and self-explanatory:
DIG-1268: Making the distinction between mapping methods and internal (or convenience) methods more clear in mappings.py
Test by generating a template with
python generate_schema.py
. You should see that the indexed_on defaults should map to a particular sheet's value and that sheet/value combination should make sense for that nested object.There should be no visible changes to the other fix: CSVConvert should work as before, maybe a little faster.