Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for treatment_type missing #33

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Hotfix for treatment_type missing #33

merged 3 commits into from
Sep 20, 2023

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Sep 17, 2023

Even though treatment_type is Required, we should be able to handle it as missing.

I also missed that radiation_therapy_fractions is an integer in the moh model, so I updated the moh_template and the diff.

I then realized that I didn't explain how to check to see if that update should happen, so I put in a convenience script to update the moh_template, and updated the README to explain how to know if you need to update and how to update.

@daisieh daisieh requested a review from yavyx September 17, 2023 19:23
@yavyx
Copy link
Contributor

yavyx commented Sep 19, 2023

Thank you, I tried editing the template myself and broke CI, so I deleted the commit :)

@daisieh
Copy link
Member Author

daisieh commented Sep 19, 2023

So does that mean the instructions are bad? Or the script is bad?

@yavyx
Copy link
Contributor

yavyx commented Sep 19, 2023

Before this PR, I noticed the same issue in the template and tried to fix it by committing directly to main, but it broke CI so I deleted it. That said, I think I understand the instructions but I find it hard to edit a diff file by hand since it needs very specific formatting and line numbers, I'm not sure if there's a better solution though.

@yavyx
Copy link
Contributor

yavyx commented Sep 19, 2023

The hotfix for missing treatments is working, I added the same line in my local branch to bypass the error.

@daisieh daisieh merged commit a5e332e into main Sep 20, 2023
@daisieh
Copy link
Member Author

daisieh commented Sep 20, 2023

Before this PR, I noticed the same issue in the template and tried to fix it by committing directly to main, but it broke CI so I deleted it. That said, I think I understand the instructions but I find it hard to edit a diff file by hand since it needs very specific formatting and line numbers, I'm not sure if there's a better solution though.

I don't think you should have to edit the diff by hand...you should be able to run the script and only commit any changes that the script makes to moh_diffs.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants