Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for katsu uuids #44

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Update for katsu uuids #44

merged 9 commits into from
Dec 4, 2023

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Dec 2, 2023

Updates to handle the changes in Katsu's schema.yml that is now being generated slightly differently.

  • DonorWithClinicalData is now named DonorWithClinicalDataSchema
  • Properties in the nested schemas are now generated alphabetically, so...
  • the submitter_*_id is not necessarily the first property. We now use the validation_schema in the MoHSchema class to find the ID name.

There are also changes to the moh_template.csv's ordering to match the new output of generate_schema.py.

These are changes required after the katsu change in DIG-1355

@daisieh daisieh requested a review from mshadbolt December 2, 2023 04:37
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Great that there weren't too many changes.

Would be good to check ingest still works as expected with the outputs once we also make required changes there too.

@daisieh daisieh merged commit f2fd4f7 into main Dec 4, 2023
1 check passed
@daisieh daisieh deleted the daisieh/uuid-update branch December 4, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants