Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation, validation and completeness summarization #64

Merged
merged 9 commits into from
May 1, 2024

Conversation

yavyx
Copy link
Contributor

@yavyx yavyx commented Apr 30, 2024

What's new

  • Added instructions to install the clinical_etl package into the virtual environment (if needed). DIG-1613
  • If a treatment start or end date is earlier than date of diagnosis, return a validation warning instead of an error.
  • Added completeness_table.py script written by @kcranston to generate a readable CSV file of the required field completeness stats.

How to test

  • pip uninstall clinical_etl from virtual environment, confirm that CSVConvert can't find the module, then reinstall with pip install -e clinical_etl_code/ and confirm it does work.
  • Create or validate a dataset with treatment start and end dates before date of diagnosis and check the warnings.
  • Run completeness_table.py with any clinical _map.json file and check the output CSV file.

@yavyx yavyx requested review from daisieh and mshadbolt April 30, 2024 22:53
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, everything works as expected.

@mshadbolt mshadbolt changed the title Yavyx/misc changes Improved documentation, validation and completeness summarization May 1, 2024
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything works as expected for me too! Thanks!

@mshadbolt mshadbolt merged commit dd30692 into develop May 1, 2024
2 checks passed
@mshadbolt mshadbolt deleted the yavyx/misc-changes branch May 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants