Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate template code #7

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Separate template code #7

merged 5 commits into from
Dec 2, 2022

Conversation

kcranston
Copy link
Member

@kcranston kcranston commented Nov 1, 2022

This separates the code for generating a template schema from the code for converting csv files. Only the former requires katsu, so we can run conversions while we debug the katsu environment issues = see #8

Template / schema generation not tested due to aforementioned environment issues.

@kcranston kcranston changed the title [WIP] Separate template code Separate template code Dec 2, 2022
@kcranston kcranston requested a review from daisieh December 2, 2022 17:58
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good plan. LGTM.

@daisieh daisieh merged commit 12f24e1 into main Dec 2, 2022
@daisieh daisieh deleted the separate-template-code branch December 2, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants