Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIG-1860: Move missing cases to validation file #89

Merged
merged 6 commits into from
Nov 18, 2024
Merged

DIG-1860: Move missing cases to validation file #89

merged 6 commits into from
Nov 18, 2024

Conversation

yavyx
Copy link
Contributor

@yavyx yavyx commented Nov 15, 2024 •
edited
Loading

Changes:

  • Moved cases_missing_data array to from _map.json to _validation results.json

  • Simplified required fields validation by uncommenting this line. Kept the specific warning when date_of_diagnosis is missing.

  • Updated test and readme

@yavyx yavyx requested review from daisieh and mshadbolt November 15, 2024 00:15
mshadbolt
mshadbolt approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work for me!

daisieh
daisieh approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yavyx yavyx merged commit e295780 into develop Nov 18, 2024
1 check passed
@yavyx yavyx deleted the yavyx/move-missing-cases branch November 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshadbolt mshadbolt mshadbolt approved these changes

@daisieh daisieh daisieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavyx @daisieh @mshadbolt