Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't write comments in sql files #236

Closed
cyyeh opened this issue Jul 13, 2023 · 0 comments · Fixed by #292
Closed

Can't write comments in sql files #236

cyyeh opened this issue Jul 13, 2023 · 0 comments · Fixed by #292
Assignees
Labels
needs-triage type/bug Something went wrong

Comments

@cyyeh
Copy link
Member

cyyeh commented Jul 13, 2023

Environment

  • Version:

    cli version: 0.6.0
    core version: 0.6.0
    build version: 0.6.0
    serve version: 0.6.0
    
  • OS: macOS with M1 chip

  • Node.js: v16.20.0

What's wrong?

Comments do not work in SQL files. After I commented on the code, the API didn't change.

example code snippet

-- SELECT 
--     businesses.*,
--     {% masking 'tips.user_id' partial(2, 'xxxxxxx', 2) %} AS tip_user_id,
--     tips.text AS tip_text,
--     tips.date AS tip_date,
--     tips.compliment_count AS tip_compliment_count
-- FROM 'data/yelp_academic_dataset_business.parquet' AS businesses
-- INNER JOIN (
--     SELECT * FROM 'data/yelp_academic_dataset_tip.parquet'
-- ) tips ON (
--     businesses.business_id = tips.business_id
-- )
-- WHERE businesses.business_id = {{ context.params.business_id | is_required }}

SELECT * FROM 'data/yelp_academic_dataset_business.parquet' AS businesses

What's the correct behavior?

I can write comments(single line and multi line) on SQL files.

Reproducing steps

Try to add comments in SQL files

@cyyeh cyyeh added type/bug Something went wrong needs-triage labels Jul 13, 2023
@kokokuo kokokuo self-assigned this Jul 14, 2023
cyyeh added a commit to cyyeh/vulcan-sql that referenced this issue Aug 30, 2023
kokokuo added a commit that referenced this issue Aug 30, 2023
fix #236, can't write comments in sql files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage type/bug Something went wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants