Feature: Path alias replacement #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar60310
force-pushed
the
feature/path-alias-replacement
branch
from
6607919 to
32d8b72
Compare
kokokuo
reviewed
Jun 27, 2022
tools/scripts/replaceAlias.ts
Outdated
| }; | ||
|
|
||
| content = content.replace(requireRegex(packageName), replacePath); | ||
| content = content.replace(importRegex(packageName), (s, _, matched) => |
There was a problem hiding this comment.
After I check the MDN replace and another example, seems the matched is the first argument and original string is the latest argument, should we check it again?
There was a problem hiding this comment.
You're right! I updated the variable name, but the logic was correct~
oscar60310
force-pushed
the
feature/builder-pattern-te
branch
from
e878082 to
20a8dce
Compare
oscar60310
force-pushed
the
feature/path-alias-replacement
branch
from
32d8b72 to
48db8eb
Compare
oscar60310
force-pushed
the
feature/path-alias-replacement
branch
from
48db8eb to
67598d7
Compare
|
@kokokuo I've fixed the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a simple script to replace the alias import such as "@vulcan/core/container" with relative pathes.
before
after