-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: dbt integration #19
Conversation
553671e
to
fa3d166
Compare
1bffa12
to
c60927e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, really easy to understand, LGTM 👍
|
||
private loadModel(name: string, node: any) { | ||
if (this.models.has(name)) throw Error(`Model name ${name} is unambiguous`); | ||
this.models.set(name, node.relation_name || `(${node.compiled_sql})`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Maybe we could add the comment to mention other members to notice here, if not found relation_name
or relation_name
is null
, then will read compiled_sql
value, how do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll account for the logic here.
Hi @kokokuo , all issues have been fixed. |
Using the result of dbt (dbt build) as API schemas.
https://www.notion.so/canner/Integration-with-dbt-61427c0571e04d82b2696f4cc50f3ff1
Feature description
DBT
Create some models and write some dbt models.
Run dbt models:
dbt run
Vulcan
Install DBT extension.
yarn add @vulcan-sql/extension-dbt
.Config extension set the path to dbt manifest files.
Reference dbt model in your SQL. (model.[project-name].[model-name])
Result
Results are variavous by materialization
Implementation
extension-dbt
for the extension andtest-utility
as a collection of testing tools like creating mock compilers ...etc.