update authentication and authorization docs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kokokuo
reviewed
Aug 3, 2023
|
|
||
| ### Providing credentials to HTTP Header | ||
|
|
||
| You need to add a header `Authorization: sample-token <token>` when sending requests, for example, sending requests with the token “another-secret”. |
There was a problem hiding this comment.
Found the typo, sample-token should be simple-token
| department: engineer | ||
| ``` | ||
|
|
||
| ### Password file |
There was a problem hiding this comment.
How about also adding the user-list section to complete the setting method? See: https://vulcan-sql-document-git-chore-bump-to-040-vulcan-sql-document.vercel.app/docs/api-building/access-control/authenticators/http-basic#user-list
There was a problem hiding this comment.
After a discussion with @cyyeh, we won't add the content to the document.
Comment on lines
+52
to
+57
| ```yaml | ||
| urlPath: /customer | ||
| profiles: | ||
| - pg-admin | ||
| - pg-non-admin | ||
| ``` |
There was a problem hiding this comment.
Should we also let users know that we could set multiple profiles, but in the SQL file, only could access one data source?
kokokuo
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update authentication and authorization docs
Issue ticket number
None
Additional Context