-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(Core, Extension-driver-canner): pass headers down to datasource & use info in API headers to connect to canner #295
Feature(Core, Extension-driver-canner): pass headers down to datasource & use info in API headers to connect to canner #295
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
186e84e
to
61a4879
Compare
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
Please assist in making the code coverage to up 80%, You could check the code coverage in the local by |
6d02de5
to
30f75ef
Compare
9be28cc
to
2bb0d9f
Compare
4b4cd67
to
2bb0d9f
Compare
…nection info of the API requester
2bb0d9f
to
3da1d84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for fixing !
Description
To use the API request context(e.g.: some customized headers) in dataSource, we need to first inject the API context into NunjucksExecutionMetadata which stores global info and passes around tag runners, and inject API context into dataSource in each tag runner.
Note
Pass API request context in the Nunjucks filter is not supported yet
Test
unit test ✅
manual integration test using canner driver ✅