Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(Core, Extension-driver-canner): pass headers down to datasource & use info in API headers to connect to canner #295

Merged
merged 8 commits into from
Sep 11, 2023

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented Sep 4, 2023

Description

To use the API request context(e.g.: some customized headers) in dataSource, we need to first inject the API context into NunjucksExecutionMetadata which stores global info and passes around tag runners, and inject API context into dataSource in each tag runner.

Note

Pass API request context in the Nunjucks filter is not supported yet

Test

unit test ✅
manual integration test using canner driver ✅

  • can use headers to access canner
截圖 2023-09-04 下午2 41 44

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 10:15am

@onlyjackfrost onlyjackfrost changed the title Feature(CORE): pass headers down to datasource Feature(CORE): pass headers down to datasource & use info in headers to connect to canner Sep 4, 2023
@onlyjackfrost onlyjackfrost changed the title Feature(CORE): pass headers down to datasource & use info in headers to connect to canner Feature(CORE, extension-driver-canner): pass headers down to datasource & use info in headers to connect to canner Sep 4, 2023
@onlyjackfrost onlyjackfrost changed the title Feature(CORE, extension-driver-canner): pass headers down to datasource & use info in headers to connect to canner Feature(Core, Extension-driver-canner): pass headers down to datasource & use info in headers to connect to canner Sep 4, 2023
@onlyjackfrost onlyjackfrost force-pushed the feature/pass-headers-down-to-datasource branch from 186e84e to 61a4879 Compare September 4, 2023 07:13
@onlyjackfrost onlyjackfrost changed the title Feature(Core, Extension-driver-canner): pass headers down to datasource & use info in headers to connect to canner Feature(Core, Extension-driver-canner): pass headers down to datasource & use info in API headers to connect to canner Sep 4, 2023
@kokokuo
Copy link
Contributor

kokokuo commented Sep 7, 2023

Please assist in making the code coverage to up 80%, You could check the code coverage in the local by nx affected:test --all --coverage first to know the reason

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing !

@onlyjackfrost onlyjackfrost merged commit fa73cfd into develop Sep 11, 2023
@onlyjackfrost onlyjackfrost deleted the feature/pass-headers-down-to-datasource branch September 11, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants