Feature: add RedShift #297
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -65,7 +65,8 @@ | |||
| "toad-scheduler": "^2.2.0", | |||
| "tslib": "^2.3.0", | |||
| "tslog": "^3.3.3", | |||
| "uuid": "^9.0.0" | |||
| "uuid": "^9.0.0", | |||
| "@aws-sdk/client-redshift-data": "^3.405.0" | |||
There was a problem hiding this comment.
I may suggest you put the @aws-sdk/client-redshift-data package in the extension-driver-redshift package, then the @aws-sdk/client-redshift-data package will only installed when user add the extension-driver-redshift
You could refer to the package.json of extension-driver-clubhouse and extension-driver-snowflake packages.
There was a problem hiding this comment.
How about using the yarn to create the yarn.lock to follow our consistency like our packages?
| "lintFilePatterns": ["packages/extension-driver-redshift/**/*.ts"] | ||
| } | ||
| }, | ||
| "test": { |
There was a problem hiding this comment.
Seems missing the publish command. Btw, after putting the @aws-sdk/client-redshift-data package in the extension-driver-redshift vulcan package, still need the install-dependencies command.
|
Close the PR since it's from forked PR. |
Description
Add Redshift as a data source
Issue ticket number
None
Additional Context