Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix incorrect condition to use restDataStream #332

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

onlyjackfrost
Copy link
Contributor

Description

The APIs with sql start with WITH RECURSIVE can not get response from server when the responding row is larger than the chunk size.

Issue ticket number

closes #324

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:24am

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7fb0de) 89.75% compared to head (8482e16) 89.75%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #332   +/-   ##
========================================
  Coverage    89.75%   89.75%           
========================================
  Files          366      366           
  Lines         6363     6364    +1     
  Branches       878      879    +1     
========================================
+ Hits          5711     5712    +1     
  Misses         476      476           
  Partials       176      176           
Flag Coverage Δ
extension-api-caller 90.00% <ø> (ø)
extension-driver-duckdb 88.03% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onlyjackfrost onlyjackfrost merged commit ea1ce87 into develop Jan 18, 2024
@hanshino hanshino deleted the fix/duckdb-recursive-query branch January 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Canner Datasource] Can choose to use cache or not when creating the caching data
2 participants