Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix CI script on develop and main branches #34

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

oscar60310
Copy link
Contributor

What's happened

We used the wrong --base argument when running tests on develop and main branches, this PR set the correct base for them:

  • In develop branch: diff with main branch.
  • In main branch: run all tests.

@oscar60310 oscar60310 requested a review from kokokuo August 18, 2022 08:15
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@7404eac). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   91.31%           
==========================================
  Files              ?      188           
  Lines              ?     2419           
  Branches           ?      274           
==========================================
  Hits               ?     2209           
  Misses             ?      165           
  Partials           ?       45           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@oscar60310 oscar60310 removed the request for review from kokokuo August 18, 2022 08:16
@oscar60310 oscar60310 changed the title FIX: Fix CI script on develop and main branches [WIP] FIX: Fix CI script on develop and main branches Aug 18, 2022
@oscar60310 oscar60310 force-pushed the fix/fix-ci-env-script branch from e9d9693 to 4089457 Compare August 18, 2022 08:37
@oscar60310 oscar60310 changed the title [WIP] FIX: Fix CI script on develop and main branches FIX: Fix CI script on develop and main branches Aug 18, 2022
@oscar60310 oscar60310 requested a review from kokokuo August 18, 2022 08:38
@oscar60310 oscar60310 force-pushed the fix/fix-ci-env-script branch from 4089457 to 1856b8d Compare August 18, 2022 08:52
Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect and fast like lightning, LTGM 👍

@kokokuo kokokuo merged commit 6ca97ec into develop Aug 18, 2022
@kokokuo kokokuo deleted the fix/fix-ci-env-script branch August 18, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants