Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement start --watch #41

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Feature: Implement start --watch #41

merged 2 commits into from
Sep 23, 2022

Conversation

oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Aug 25, 2022

Description

Provide a flag --watch, -w for start command, which lets the server watch SQL and schemas changes, and restart the server when needed.

Issue ticket number

closes #60

Additional Context

  • Watch flag doesn't work in docker CLI, we might need another solution (e.g. polling) for it.

@oscar60310 oscar60310 force-pushed the chore/vulcan-lab branch 2 times, most recently from c70ec05 to 5730b0b Compare August 31, 2022 09:18
Base automatically changed from chore/vulcan-lab to develop September 6, 2022 08:28
@oscar60310 oscar60310 linked an issue Sep 22, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 92.73% // Head: 92.53% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (1234fdd) compared to base (2a5e525).
Patch coverage: 83.51% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage    92.73%   92.53%   -0.21%     
===========================================
  Files          229      229              
  Lines         3223     3294      +71     
  Branches       392      404      +12     
===========================================
+ Hits          2989     3048      +59     
- Misses         168      170       +2     
- Partials        66       76      +10     
Flag Coverage Δ
build 94.87% <ø> (ø)
cli 88.96% <83.51%> (-1.99%) ⬇️
core 93.22% <ø> (ø)
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
extension-driver-duckdb 100.00% <ø> (ø)
integration-testing 96.15% <ø> (ø)
serve 90.12% <ø> (ø)
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cli/src/cli.ts 95.83% <ø> (ø)
packages/cli/src/utils/shutdown.ts 85.71% <75.00%> (-1.79%) ⬇️
packages/cli/src/commands/start.ts 80.30% <80.30%> (-19.70%) ⬇️
packages/cli/src/commands/serve.ts 96.87% <93.33%> (+0.87%) ⬆️
packages/cli/src/commands/build.ts 100.00% <100.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oscar60310 oscar60310 changed the title [WIP] Feature: Implement start --watch Feature: Implement start --watch Sep 22, 2022
@oscar60310 oscar60310 marked this pull request as ready for review September 22, 2022 08:28
@oscar60310 oscar60310 requested a review from kokokuo September 22, 2022 08:28
Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@kokokuo
Copy link
Contributor

kokokuo commented Sep 22, 2022

cc @oscar60310 There is a conflict need to solve.

@oscar60310 oscar60310 merged commit 46c0080 into develop Sep 23, 2022
@hanshino hanshino deleted the feature/cli-watch branch January 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI —watch support
3 participants