Feature: Driver - duckdb #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar60310
force-pushed
the
feature/driver-duckdb
branch
from
75842ab to
21d7293
Compare
Codecov ReportBase: 92.59% // Head: 92.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## fix/response-streams #43 +/- ##
========================================================
+ Coverage 92.59% 92.67% +0.08%
========================================================
Files 222 224 +2
Lines 3051 3098 +47
Branches 351 358 +7
========================================================
+ Hits 2825 2871 +46
- Misses 165 166 +1
Partials 61 61
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
oscar60310
force-pushed
the
feature/driver-duckdb
branch
from
21d7293 to
fc25b8a
Compare
oscar60310
force-pushed
the
feature/driver-duckdb
branch
2 times, most recently
from
a3ac76f to
1d639d2
Compare
kokokuo
approved these changes
Sep 7, 2022
labs/playground1/Makefile
Outdated
|
|
||
| # build the required packages | ||
| build: pkg-core pkg-build pkg-serve pkg-cli | ||
| build: pkg-core pkg-build pkg-serve pkg-cli pkg-serve pkg-extension-driver-duckdb |
There was a problem hiding this comment.
why execute pkg-serve twice ( after the pkg-cli ), is it a typo?
There was a problem hiding this comment.
Yes, typo here, thanks!
types/duckdb.d.ts
Outdated
| */ | ||
| run(sql: string, ...params: any): void; // This last parameter should be callback function. | ||
| /** | ||
| * Convenience method for Connection#apply using a built-in default connection |
oscar60310
force-pushed
the
feature/driver-duckdb
branch
from
1d639d2 to
7baecda
Compare
|
Hi @kokokuo , all issues have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver for duckdb
Document:
https://github.com/Canner/vulcan/tree/feature/driver-duckdb/packages/extension-driver-duckdb
I deleted the extension for lab env because it can use this driver instead.