Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix default tag name of npm #44

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

oscar60310
Copy link
Contributor

NX sends string "undefined" when flag is not provided.

@oscar60310 oscar60310 requested a review from kokokuo September 2, 2022 05:30
@codecov-commenter
Copy link

Codecov Report

Base: 92.08% // Head: 92.08% // No change to project coverage 👍

Coverage data is based on head (54410fb) compared to base (9a03213).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #44   +/-   ##
========================================
  Coverage    92.08%   92.08%           
========================================
  Files          215      215           
  Lines         2980     2980           
  Branches       346      346           
========================================
  Hits          2744     2744           
  Misses         172      172           
  Partials        64       64           
Flag Coverage Δ
build 94.87% <ø> (ø)
cli 91.90% <ø> (ø)
core 92.45% <ø> (ø)
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
integration-testing 96.42% <ø> (ø)
serve 88.82% <ø> (ø)
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kokokuo kokokuo merged commit e664088 into develop Sep 5, 2022
@oscar60310 oscar60310 deleted the fix/fix-publish-script branch September 6, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants