-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: New driver - pg #78
Conversation
78adf04
to
f2ce245
Compare
Codecov ReportBase: 92.52% // Head: 92.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #78 +/- ##
===========================================
+ Coverage 92.52% 92.58% +0.05%
===========================================
Files 245 248 +3
Lines 3533 3613 +80
Branches 446 453 +7
===========================================
+ Hits 3269 3345 +76
- Misses 179 183 +4
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
115504e
to
9848eaf
Compare
a9a3b64
to
fae809a
Compare
fae809a
to
6913f4b
Compare
34441c8
to
b41d3fc
Compare
6913f4b
to
b3e776b
Compare
6788caa
to
053b839
Compare
@kokokuo I've solved the conflicts, and this PR is ready for review. |
- rename the mock driver from pg to mock for the incoming driver
- test pg driver with docker container - fix some pool leak issues BREAKING CHANGE: we need docker host to run our tests now
053b839
to
b514d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 👍
@oscar60310, just have a question after I also develop another data source, why do we need to do the |
For generating the response schema in the specification. PG (or other data sources) has lots of data types, e.g. int2, int4, etc., but our API spec only has some basic types: |
Thanks so much!!!! I'm working ClickHouse now, it really helpful for me to handle it 😀 Also cc @JSYOU, @onlyjackfrost, @andreashimin, @fredalai, and @wwwy3y3 to know the the reason. |
Description
Issue ticket number
closes #56
Additional Context