Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix dependencies issues #81

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Conversation

oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Sep 22, 2022

Description

The package.json of serve package missed two packages:

  • redoc: because we imported it at run time only. I won't import it because we only use the bundle result, but not the source.
  • bcryptjs: because we set it to dev dependencies

This PR fix these issues.

Issue ticket number

N/A quick fix

Additional Context

Related to #38 #26

@oscar60310 oscar60310 requested a review from kokokuo September 22, 2022 08:56
@oscar60310 oscar60310 force-pushed the fix/fix-dependencies-issues branch from f43d8d7 to 10f9aea Compare September 22, 2022 09:00
@oscar60310 oscar60310 changed the title Fix/fix dependencies issues Fix: Fix dependencies issues Sep 22, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 92.76% // Head: 92.76% // No change to project coverage 👍

Coverage data is based on head (10f9aea) compared to base (6121276).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #81   +/-   ##
========================================
  Coverage    92.76%   92.76%           
========================================
  Files          229      229           
  Lines         3221     3221           
  Branches       392      392           
========================================
  Hits          2988     2988           
  Misses         167      167           
  Partials        66       66           
Flag Coverage Δ
build 94.87% <ø> (ø)
cli 90.95% <ø> (ø)
core 93.22% <ø> (ø)
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
extension-driver-duckdb 100.00% <ø> (ø)
integration-testing 96.15% <ø> (ø)
serve 90.22% <ø> (ø)
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kokokuo kokokuo merged commit fc8973a into develop Sep 22, 2022
@hanshino hanshino deleted the fix/fix-dependencies-issues branch January 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants