Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: production build #82

Merged
merged 8 commits into from
Sep 24, 2022
Merged

Feature: production build #82

merged 8 commits into from
Sep 24, 2022

Conversation

oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Sep 22, 2022

Description

Provide package command to do production builds, and use --output flag to indicate the output type.

  • Node:
    Build: vulcan package --output node
    Execute: npm install && node ./dist/index.js
  • Docker
    Build: vulcan package --output node && docker build ./dist
    Execute docker run xxx

Issue ticket number

closes #50

Additional Context

  • I update our artifact builder. We need to use getArtifact to get the content now. cc @wwwy3y3
      await artifactBuilder.load();
      const templates = artifactBuilder.getArtifact(
        BuiltInArtifactKeys.Templates
      );
      const schemas = artifactBuilder.getArtifact<APISchema[]>(
        BuiltInArtifactKeys.Schemas
      );
  • Breaking changes:
    • Remove spec-xxx.yaml files, they'll be wrapped into result.json now.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 92.72% // Head: 92.81% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (406ebed) compared to base (bf6ae32).
Patch coverage: 96.18% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #82      +/-   ##
===========================================
+ Coverage    92.72%   92.81%   +0.09%     
===========================================
  Files          245      254       +9     
  Lines         3462     3565     +103     
  Branches       434      441       +7     
===========================================
+ Hits          3210     3309      +99     
- Misses         177      179       +2     
- Partials        75       77       +2     
Flag Coverage Δ
build 94.88% <97.43%> (+0.33%) ⬆️
cli 91.25% <94.59%> (+0.29%) ⬆️
core 93.22% <88.88%> (-0.04%) ⬇️
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
extension-driver-duckdb 100.00% <ø> (ø)
integration-testing 96.15% <ø> (ø)
serve 90.27% <100.00%> (+0.08%) ⬆️
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/build/src/containers/types.ts 100.00% <ø> (ø)
packages/core/src/models/documentOptions.ts 100.00% <ø> (ø)
.../integration-testing/src/example1/projectConfig.ts 100.00% <ø> (ø)
.../src/lib/artifact-builder/vulcanArtifactBuilder.ts 93.75% <85.71%> (-6.25%) ⬇️
packages/cli/src/commands/package.ts 92.30% <92.30%> (ø)
packages/build/src/lib/packager/nodePackager.ts 94.11% <94.11%> (ø)
.../src/lib/packager/dockerPackager/dockerPackager.ts 94.44% <94.44%> (ø)
packages/build/src/containers/container.ts 63.15% <100.00%> (+2.04%) ⬆️
packages/build/src/containers/modules/extension.ts 100.00% <100.00%> (ø)
packages/build/src/containers/modules/index.ts 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oscar60310 oscar60310 force-pushed the feature/production-build branch from 60b1350 to 406ebed Compare September 23, 2022 03:46
@oscar60310 oscar60310 marked this pull request as ready for review September 23, 2022 04:10
@oscar60310 oscar60310 changed the title [WIP] Feature: production build Feature: production build Sep 23, 2022
@oscar60310 oscar60310 requested a review from kokokuo September 23, 2022 04:10
Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@kokokuo kokokuo merged commit c9e7513 into develop Sep 24, 2022
@kokokuo kokokuo deleted the feature/production-build branch September 24, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production build with Node and Docker
3 participants