Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix format error when url is not found #87

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Sep 23, 2022

Description

Format middleware now only handles Vulcan APIs.

Issue ticket number

closes #84

Additional Context

  • Hardcoding API in middleware is a temporary solution, we should use a configurable path instead.

@oscar60310 oscar60310 requested a review from kokokuo September 23, 2022 16:40
@oscar60310 oscar60310 changed the title FIX: Fix format error when url is not found Fix: Fix format error when url is not found Sep 23, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 92.52% // Head: 90.36% // Decreases project coverage by -2.16% ⚠️

Coverage data is based on head (af0cc72) compared to base (46c0080).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
- Coverage    92.52%   90.36%   -2.17%     
===========================================
  Files          245       68     -177     
  Lines         3533      965    -2568     
  Branches       446      151     -295     
===========================================
- Hits          3269      872    -2397     
+ Misses         179       70     -109     
+ Partials        85       23      -62     
Flag Coverage Δ
build ?
cli ?
core ?
extension-dbt ?
extension-debug-tools ?
extension-driver-duckdb ?
integration-testing 96.15% <ø> (ø)
serve 90.20% <100.00%> (+0.01%) ⬆️
test-utility ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/src/lib/middleware/response-format/middleware.ts 82.14% <100.00%> (+0.66%) ⬆️
packages/cli/src/commands/init.ts
...es/build/src/lib/schema-parser/middleware/index.ts
packages/cli/src/utils/module.ts
...src/lib/schema-parser/middleware/setConstraints.ts
packages/build/src/containers/modules/index.ts
...ckages/extension-debug-tools/src/lib/astPrinter.ts
...alidators/built-in-validators/requiredValidator.ts
...built-in-extensions/query-builder/parameterizer.ts
.../src/lib/artifact-builder/vulcanArtifactBuilder.ts
... and 168 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍 Thanks so much for finding and fixing the formatter issues about formatting all apis !

@kokokuo kokokuo merged commit 3d2639d into develop Sep 24, 2022
@kokokuo kokokuo deleted the fix/fix-format-issues branch September 24, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix format error when url is not found
3 participants