-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Throw errors with proper http code #89
Conversation
- add error handler middleware. - fix the middleware order in order to get request id.
Codecov ReportBase: 92.68% // Head: 92.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #89 +/- ##
===========================================
- Coverage 92.68% 92.60% -0.09%
===========================================
Files 257 259 +2
Lines 3720 3798 +78
Branches 462 481 +19
===========================================
+ Hits 3448 3517 +69
Misses 185 185
- Partials 87 96 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for pointing out, that property is optional, builder won't send sample queries without setting it. So I think it's ok to leave it blank in init templates. |
If not set it, does the api spec still generated but not appear the response info in the api document? ( I would like to check for writing it to the our vulcansql document ) |
Yes, we'll get an empty response {} in the document. |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 👍 👍
Thanks so much for helping me to develop the feature, really appreciated
Description
I've created 4 errors for us:
Issue ticket number
closes #61
Additional Context