Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger #575

Merged
merged 1 commit into from
May 29, 2024
Merged

Add logger #575

merged 1 commit into from
May 29, 2024

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented May 28, 2024 •
edited
Loading

I added a logger.py to wrap the logging for basic config like log level could be one side.

Before we import logging then use getLogger(name), we should from app.logger import get_logger instead of it.

@grieve54706 grieve54706 requested a review from goldmedal May 28, 2024 07:46
@goldmedal
Copy link
Contributor

Could you add some example to show how to use this logger?

goldmedal
goldmedal approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldmedal goldmedal merged commit f7e63ba into main May 29, 2024
@goldmedal goldmedal deleted the feature/ibis/logger branch May 29, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grieve54706 @goldmedal