Add dryRun parameter for query API #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And split ibis.py by data source
grieve54706
force-pushed
the
feature/ibis/dry-run
branch
from
64e6327 to
437a9ed
Compare
goldmedal
approved these changes
Jun 5, 2024
ibis-server/app/model/coordinator.py
Outdated
| from app.model.data_source import DataSource, ConnectionInfo | ||
|
|
||
|
|
||
| class Coordinator: |
There was a problem hiding this comment.
Suggested change
| class Coordinator: | |
| class Connector: |
How about calling it Connector? It's not a distributed architecture. Coordinator might not be suitable.
There was a problem hiding this comment.
Sure, nice name. Thanks.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dryRunparameter for query API and splitibis.pyby data source.Example:
If successful, it will return HTTP status code
204. If it fails, it will return HTTP status code422.