Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff for python CI flow #601

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Add ruff for python CI flow #601

merged 2 commits into from
Jun 7, 2024

Conversation

grieve54706
Copy link
Contributor

Add ruff for lint and format.
Add pre-commit to check lint and format.
Add action to check lint and format.

@grieve54706 grieve54706 requested a review from goldmedal June 6, 2024 11:08
@grieve54706 grieve54706 force-pushed the chore/ibis/ruff-lint branch from 5dbd482 to a2d6f91 Compare June 6, 2024 11:10
@goldmedal goldmedal changed the title Add ruff Add ruff for python CI flow Jun 7, 2024
@goldmedal
Copy link
Contributor

I changed the title to Add ruff for python CI flow

@goldmedal
Copy link
Contributor

I found you commit a new file ibis-server/.pre-commit-config.yaml. Should we add it to gitignore list?

@grieve54706
Copy link
Contributor Author

I found you commit a new file ibis-server/.pre-commit-config.yaml. Should we add it to gitignore list?

No, it should be committed to repo. Every contributor should follow the rules.

Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 -- LGTM

@goldmedal goldmedal merged commit db7553b into main Jun 7, 2024
1 check passed
@goldmedal goldmedal deleted the chore/ibis/ruff-lint branch June 7, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants