Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove unused dependency #803

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore(core): remove unused dependency #803

merged 1 commit into from
Sep 26, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Sep 25, 2024 •
edited
Loading

Description

  • Remove the unnecessary feature from DataFusion dependency. Take expression-related features only.
  • Change the building profile to release

In my local environment, before removing them, the building time is

    Finished release profile [optimized] target(s) in 8m 43s

After removing them, the time is

    Finished release profile [optimized] target(s) in 7m 30s

@goldmedal goldmedal changed the title feature(core): remove unused dependency chore(core): remove unused dependency Sep 25, 2024
@goldmedal goldmedal marked this pull request as ready for review September 26, 2024 02:06
grieve54706
grieve54706 reviewed Sep 26, 2024
View reviewed changes
wren-modeling-py/pyproject.toml
@@ -17,6 +17,7 @@ pytest = "8.3.3"

[tool.maturin]
module-name = "wren_core"
profile = "release"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release profile will optimize the binary more.

grieve54706
grieve54706 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldmedal goldmedal merged commit babe89f into Canner:main Sep 26, 2024
19 of 21 checks passed
@goldmedal goldmedal deleted the chore/remove-unused-dependency branch September 26, 2024 03:28
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
@goldmedal
chore(core): remove unused dependency (#803)
0f3672f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldmedal @grieve54706