Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make test use fixture #997

Merged
merged 3 commits into from
Dec 19, 2024
Merged

test: make test use fixture #997

merged 3 commits into from
Dec 19, 2024

Conversation

grieve54706
Copy link
Contributor

Use the same one client to avoid unnecessary lifespan trigger.

@github-actions github-actions bot added ibis python Pull requests that update Python code labels Dec 19, 2024
@grieve54706 grieve54706 force-pushed the chore/make-test-use-fixture branch from d6a0e24 to 6505d51 Compare December 19, 2024 09:08
@grieve54706 grieve54706 marked this pull request as draft December 19, 2024 09:41
@grieve54706 grieve54706 removed the request for review from goldmedal December 19, 2024 09:41
@grieve54706 grieve54706 marked this pull request as ready for review December 19, 2024 10:11
@goldmedal goldmedal merged commit 2a99990 into main Dec 19, 2024
7 checks passed
@goldmedal goldmedal deleted the chore/make-test-use-fixture branch December 19, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibis python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants