feat(core): implement the dialect-specific function unparsing #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
ibis
rust
grieve54706
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #946
The root cause of #946 is
trimis the alias ofbtrimin the DataFusion. Thebtrimfunction call plan will be generated when we plan the SQL to the logical plan. That's why we got thebtrimin the unparsing result. In this case, we need to override the behavior of SQL generation. This PR supports thetrimfunction for MySQL. We can follow this pattern to support the similar cases for other data sources.Changed
InnerDialectto customize the function unparsing behavior for different data source.trimto the function white list of MySQL