parse more largely from stdout and not jus stderr #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to #124 especially, we're more likely to receive test failure abstracts on stdout and not just stderr Fix #317
|
As this PR may introduce regressions, I'd welcome tests. |
This was referenced Jun 17, 2023
|
in main.rs I added: #[cfg(test)]
mod tests {
#[test]
fn test_1() {
assert!(false);
}
#[test]
fn test_2() {
assert!(false);
}
#[test]
fn test_3() {
assert!(false);
}
#[test]
fn test_4() {
assert!(false);
}
#[test]
fn test_5() {
assert!(false);
}
#[test]
fn test_6() {
assert!(false);
}
#[test]
fn test_7() {
assert!(false);
}
#[test]
fn test_8() {
assert!(false);
}
#[test]
fn test_9() {
assert!(false);
}
#[test]
fn test_10() {
assert!(false);
}
#[test]
fn test_11() {
assert!(false);
}
#[test]
fn test_12() {
assert!(false);
}
#[test]
fn test_13() {
assert!(false);
}
#[test]
fn test_14() {
assert!(false);
}
#[test]
fn test_15() {
assert!(false);
}
#[test]
fn test_16() {
assert!(false);
}
#[test]
fn test_17() {
assert!(false);
}
#[test]
fn test_18() {
assert!(false);
}
#[test]
fn test_19() {
assert!(false);
}
#[test]
fn test_20() {
assert!(false);
}
}cargo run -- test works fine scrolling shows the rest: In bacon.toml I added: [jobs.nextest]
command = ["cargo", "nextest", "run", "--color", "always"]
need_stdout = truecargo run --nextest is pretty odd: |
|
nextest would need an adapted parsing, which could be done but there's a bigger problems: |
|
This PR works for me! I'm on macOS Alacritty, using the default test runner. |
|
This PR works for me, too. (macOS, WezTerm terminal, default test runner) |
|
I typically use In case it is helpful, I also tried this PR with nextest: Then added the following to [jobs.nextest]
command = [
"cargo", "nextest", "run", "--color", "always",
]
need_stdout = trueWith a test suite where all tests pass, I do get colored output: 
Here's what bacon reports when two tests fail: Again, output is colorized, but bacon does not yet parse nextest's output correctly—similar to what @Canop said above in #140 (comment). That said, maybe nextest support should be moved into a separate GH issue? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #124 especially, we're more likely to receive test failure abstracts on stdout and not just stderr.
With this PR, lines from stdout are better parsed.
Fix #137