-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_equivalence_ratio
to SolutionArray
objects
#604
Comments
Should the size of the arrays in |
Yes, I would expect this to work the same way as the other setters, e.g. |
I do have a question regarding the envisioned scope of |
@ischoegl I suspect that any serialization output routine for 1-D classes will be in the C++ layer so that any interface could use it. However, I think it's possible that having a specialized subclass of |
Thanks for the insights: I agree that a subclass of SolutionArray handling 1D would be useful, which is what also prompted my inquiry. Has there been any discussion on what the new C++ layer replacing XML could entail? |
Currently, the Python
SolutionArray
class has no equivalent ofThermoPhase.set_equivalence_ratio
. A version of this function could be added to theSolutionArray
class so that one can set the equivalence ratio to a range of values. This would make calculation of an adiabatic flame temperature curve very simple:This function could also enable specifying a range of fuel and/or oxidizer compositions, in the case where a
dict
is used for the composition:The text was updated successfully, but these errors were encountered: