Add set_equivalence_ratio to SolutionArray objects #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speth
requested changes
Aug 6, 2019
ischoegl
force-pushed
the
add-set-equivalence-ratio-to-solution-array
branch
from
205a78a to
201a5f8
Compare
|
Done and pushed. Let's see whether unit tests do their job ... |
ischoegl
force-pushed
the
add-set-equivalence-ratio-to-solution-array
branch
from
201a5f8 to
c31a351
Compare
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 70.62% 70.62% +<.01%
==========================================
Files 372 372
Lines 43565 43565
==========================================
+ Hits 30768 30769 +1
+ Misses 12797 12796 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 70.62% 70.62% +<.01%
==========================================
Files 372 372
Lines 43565 43565
==========================================
+ Hits 30768 30769 +1
+ Misses 12797 12796 -1
Continue to review full report at Codecov.
|
|
unit tests work ;) |
speth
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the issue number this pull request is fixing:
Fixes #604
Changes proposed in this pull request:
ThermoPhase.set_equivalence_ratio, and check dimensions