Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions in PR template #1032

Merged
merged 1 commit into from
May 10, 2021
Merged

Update instructions in PR template #1032

merged 1 commit into from
May 10, 2021

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented May 10, 2021 •
edited
Loading

Changes proposed in this pull request

Update instructions in pull request template to encourage contributors to provide adequate information on their PR.

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl mentioned this pull request May 10, 2021
Closed
@ischoegl ischoegl requested a review from a team May 10, 2021 12:51
@speth speth merged commit b107d13 into Cantera:main May 10, 2021
@ischoegl ischoegl deleted the update-PR-template2 branch June 22, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speth speth speth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischoegl @speth