Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendations for whitespace use to CONTRIBUTING.md #1121

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Oct 17, 2021

Changes proposed in this pull request

This PR adds recommendations for whitespace use to CONTRIBUTING.md. While these formatting recommendations were not pointed out in the style guidelines, they have been frequently provided in review comments

@ischoegl ischoegl mentioned this pull request Oct 17, 2021
5 tasks
@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1121 (ff8d030) into main (be95118) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         364      364           
  Lines       47882    47882           
=======================================
  Hits        35170    35170           
  Misses      12712    12712           
Impacted Files Coverage Δ
src/thermo/PengRobinson.cpp 88.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27eb1f...ff8d030. Read the comment docs.

@ischoegl ischoegl requested review from bryanwweber and speth October 17, 2021 18:54
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.

@speth speth merged commit 1710352 into Cantera:main Oct 18, 2021
@ischoegl ischoegl deleted the whitespace-recommendations branch October 20, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants