Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0.0a5 #1474

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Bump version to 3.0.0a5 #1474

merged 3 commits into from
Apr 16, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Apr 11, 2023

Changes proposed in this pull request

Bumping version, so recent updates (generalized preconditioning and SolutionArray) become accessible in conda packages (contingent on review/merge of #1471). Also fixing minor issues with doxygen docstrings and ordering of components.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the bump-to-3.0.0a5 branch 2 times, most recently from 71e9676 to 561ddf2 Compare April 12, 2023 00:28
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1474 (da1646e) into main (9f25dd5) will increase coverage by 0.10%.
The diff coverage is 89.51%.

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   69.95%   70.06%   +0.10%     
==========================================
  Files         377      377              
  Lines       57533    57788     +255     
  Branches    19281    19410     +129     
==========================================
+ Hits        40250    40489     +239     
- Misses      14729    14738       +9     
- Partials     2554     2561       +7     
Impacted Files Coverage Δ
include/cantera/base/SolutionArray.h 94.44% <ø> (ø)
interfaces/cython/cantera/ck2yaml.py 88.96% <ø> (ø)
interfaces/cython/cantera/cti2yaml.py 77.51% <ø> (ø)
interfaces/cython/cantera/ctml2yaml.py 84.50% <ø> (ø)
src/thermo/ThermoFactory.cpp 74.15% <ø> (ø)
interfaces/cython/cantera/_onedim.pyx 81.95% <33.33%> (+0.17%) ⬆️
src/base/Storage.cpp 79.48% <80.00%> (+0.05%) ⬆️
interfaces/cython/cantera/solutionbase.pyx 89.34% <85.71%> (-0.30%) ⬇️
src/base/SolutionArray.cpp 78.54% <89.95%> (+2.38%) ⬆️
include/cantera/oneD/StFlow.h 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ischoegl ischoegl marked this pull request as ready for review April 14, 2023 19:37
@ischoegl
Copy link
Member Author

ischoegl commented Apr 14, 2023

Finally ready for review ... Edit: also rebased

@ischoegl ischoegl requested a review from a team April 14, 2023 19:39
A domain may define extra state entries added after species, where the
appropriate order needs to be maintained.
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@speth speth merged commit 055a530 into Cantera:main Apr 16, 2023
@ischoegl ischoegl deleted the bump-to-3.0.0a5 branch April 16, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants