Introduce unstrained-flow for BurnerFlame

[ischoegl]

Changes proposed in this pull request

Prior to this PR, BurnerFlame used an AxisymmetricFlow domain, despite spread_rate and lambda not being used.

• Introduce new unstrained-flow domain
• spread_rate and lambda are deactivated in output

If applicable, fill in the issue number this pull request is fixing

Resolves Cantera/enhancements#171

If applicable, provide an example illustrating new features this pull request is introducing

In [2]: %run burner_flame.py
[...]
Solution saved to 'burner_flame.csv'.

In [3]: f.to_array()
Out[3]:
            grid velocity         T          D  ...          HO2         H2O2        AR           N2
0    0.00000e+00  1.10292   373.000  0.0544011  ...  2.00004e-05  2.32431e-06  0.888904  6.64916e-15
1    1.22070e-05  1.10378   373.300  0.0543589  ...  2.04091e-05  2.37217e-06  0.888905 -3.57185e-15
2    2.44141e-05  1.10464   373.600  0.0543165  ...  2.07800e-05  2.42012e-06  0.888906 -2.00555e-15
3    3.66211e-05  1.10550   373.903  0.0542740  ...  2.11161e-05  2.46816e-06  0.888906  2.01846e-15
4    4.88281e-05  1.10637   374.206  0.0542313  ...  2.14203e-05  2.51625e-06  0.888907  8.48023e-15
..           ...      ...       ...        ...  ...          ...          ...       ...          ...
127  3.00000e-01  5.02974  1820.690  0.0119291  ...  4.07495e-07  2.00177e-08  0.888643 -1.31704e-14
128  3.25000e-01  5.05705  1831.589  0.0118646  ...  3.91957e-07  1.87521e-08  0.888642 -1.31743e-14
129  3.50000e-01  5.08146  1841.332  0.0118076  ...  3.78360e-07  1.76830e-08  0.888642 -1.32409e-14
130  4.25000e-01  5.13671  1863.292  0.0116806  ...  3.49561e-07  1.55033e-08  0.888639 -1.32705e-14
131  5.00000e-01  5.13671  1863.292  0.0116806  ...  3.49561e-07  1.55033e-08  0.888639 -1.32705e-14

[132 rows x 14 components; state='TDY']

Before this change, the output was

In [1]: %run burner_flame.py
[...]
Solution saved to 'burner_flame.csv'.

In [2]: f.to_array()
Out[2]:
            grid velocity spread_rate lambda         T  ...          HO2         H2O2        AR           N2
0    0.00000e+00  1.10292           0      0   373.000  ...  2.00004e-05  2.32431e-06  0.888904  6.64916e-15
1    1.22070e-05  1.10378           0      0   373.300  ...  2.04091e-05  2.37217e-06  0.888905 -3.57185e-15
2    2.44141e-05  1.10464           0      0   373.600  ...  2.07800e-05  2.42012e-06  0.888906 -2.00555e-15
3    3.66211e-05  1.10550           0      0   373.903  ...  2.11161e-05  2.46816e-06  0.888906  2.01846e-15
4    4.88281e-05  1.10637           0      0   374.206  ...  2.14203e-05  2.51625e-06  0.888907  8.48023e-15
..           ...      ...         ...    ...       ...  ...          ...          ...       ...          ...
127  3.00000e-01  5.02974           0      0  1820.690  ...  4.07495e-07  2.00177e-08  0.888643 -1.31704e-14
128  3.25000e-01  5.05705           0      0  1831.589  ...  3.91957e-07  1.87521e-08  0.888642 -1.31743e-14
129  3.50000e-01  5.08146           0      0  1841.332  ...  3.78360e-07  1.76830e-08  0.888642 -1.32409e-14
130  4.25000e-01  5.13671           0      0  1863.292  ...  3.49561e-07  1.55033e-08  0.888639 -1.32705e-14
131  5.00000e-01  5.13671           0      0  1863.292  ...  3.49561e-07  1.55033e-08  0.888639 -1.32705e-14

[132 rows x 16 components; state='TDY']

where spread_rate and lambda do not add information.

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Merging #1477 (dc0bdb1) into main (708a8bf) will decrease coverage by 0.01%.
The diff coverage is 90.47%.

❗ Current head dc0bdb1 differs from pull request most recent head 3d9112f. Consider uploading reports for the commit 3d9112f to get more accurate results

@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
- Coverage   70.05%   70.05%   -0.01%     
==========================================
  Files         377      377              
  Lines       57773    57787      +14     
  Branches    19406    19410       +4     
==========================================
+ Hits        40473    40481       +8     
- Misses      14739    14745       +6     
  Partials     2561     2561              

Impacted Files	Coverage Δ
interfaces/cython/cantera/_onedim.pyx	81.95% <33.33%> (+0.17%)	⬆️
include/cantera/oneD/StFlow.h	100.00% <100.00%> (ø)
interfaces/cython/cantera/onedim.py	88.74% <100.00%> (ø)
src/oneD/DomainFactory.cpp	90.69% <100.00%> (+0.95%)	⬆️
src/oneD/StFlow.cpp	83.92% <100.00%> (+0.05%)	⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ischoegl]

@speth ... thanks for the suggestion. I updated accordingly.

[speth]

Thanks, @ischoegl. This looks good to me.