-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1525 #1569
Fix #1525 #1569
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
+ Coverage 70.45% 70.47% +0.01%
==========================================
Files 379 379
Lines 59093 59093
Branches 21230 21230
==========================================
+ Hits 41636 41643 +7
+ Misses 14376 14369 -7
Partials 3081 3081 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. That's simpler than I thought it would be!
Is pint tested anywhere on CI still after these removals? |
Yes, if you look at |
Thank you! I didn't check, sorry |
@bryanwweber’s comment on #1525 was key .. |
Changes proposed in this pull request
Avoid test failures if optional
pint
package is not foundIf applicable, fill in the issue number this pull request is fixing
Closes #1525
Checklist
scons build
&scons test
) and unit tests address code coverage