Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1525 #1569

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Fix #1525 #1569

merged 2 commits into from
Aug 6, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 4, 2023

Changes proposed in this pull request

Avoid test failures if optional pint package is not found

If applicable, fill in the issue number this pull request is fixing

Closes #1525

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl added tests Issues about tests, running the tests, or test results CI labels Aug 4, 2023
@ischoegl ischoegl marked this pull request as ready for review August 4, 2023 14:46
@ischoegl ischoegl requested a review from a team August 4, 2023 14:47
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1569 (5b9766c) into main (6ba497c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
+ Coverage   70.45%   70.47%   +0.01%     
==========================================
  Files         379      379              
  Lines       59093    59093              
  Branches    21230    21230              
==========================================
+ Hits        41636    41643       +7     
+ Misses      14376    14369       -7     
  Partials     3081     3081              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ischoegl ischoegl added the Python label Aug 4, 2023
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. That's simpler than I thought it would be!

@bryanwweber
Copy link
Member

Is pint tested anywhere on CI still after these removals?

@speth
Copy link
Member

speth commented Aug 6, 2023

Yes, if you look at main.yaml, you will see that it is still installed for almost all of the runners. The cases it is removed from represent ~7 of the ~40 CI runs (and we weren't even running the tests that use pint for the various Sundials versions anyway).

@bryanwweber
Copy link
Member

Thank you! I didn't check, sorry

@ischoegl ischoegl merged commit 8ab4214 into Cantera:main Aug 6, 2023
@ischoegl ischoegl deleted the skip-pint branch August 6, 2023 16:18
@ischoegl
Copy link
Member Author

ischoegl commented Aug 6, 2023

Thanks, @ischoegl. That's simpler than I thought it would be!

@bryanwweber’s comment on #1525 was key ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Python tests Issues about tests, running the tests, or test results
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make pint optional when running tests
3 participants