Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to build 1.0 for sdist #1625

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Conversation

speth
Copy link
Member

@speth speth commented Sep 24, 2023

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

This should fix the current error that's breaking the PyPI package builds.

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #1625 (e482b19) into main (baf28af) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   72.71%   72.70%   -0.01%     
==========================================
  Files         370      370              
  Lines       56286    56286              
  Branches    20368    20368              
==========================================
- Hits        40927    40924       -3     
- Misses      12363    12365       +2     
- Partials     2996     2997       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - @bryanwweber its up to you though (saw the specific review request too late)

@bryanwweber bryanwweber merged commit 9696e27 into Cantera:main Sep 24, 2023
@bryanwweber
Copy link
Member

Merged, thanks @speth

@speth speth deleted the sdist-build-1.0 branch September 24, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants