-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new home for data files used in examples #1689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
+ Coverage 72.76% 72.82% +0.05%
==========================================
Files 378 378
Lines 56986 56955 -31
Branches 20691 20681 -10
==========================================
+ Hits 41468 41478 +10
+ Misses 12463 12424 -39
+ Partials 3055 3053 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Minor comment but would also be interested in @bryanwweber’s input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, aside from the one minor comment!
This was broken by the removal of the build/data directory in Cantera#1689.
This was broken by the removal of the build/data directory in #1689.
This was broken by the removal of the build/data directory in Cantera#1689.
Changes proposed in this pull request
This PR is the implementation of an idea I suggested in Cantera/enhancements#22 (comment).
example_data
, install these data files when installing CanteraSConstruct
build/data
I don't regard this as the final word on which files belong in the
data
directory of the of this repo and which ones should be moved tocantera-example-data
. So far, I've only moved those data files that were only used in examples into the submodule. If we want to move any other files, it will take a bit of work to extricate them from the test suite.If applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#22
If applicable, provide an example illustrating new features this pull request is introducing
Files from the
cantera-example-data
repository can be loaded by specifying the path relative to the base Cantera data directory:Checklist
scons build
&scons test
) and unit tests address code coverage