[python] Fix dimension of sliced SolutionArray methods #1726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Solution
methodsSolutionArray
methods when phase is anInterface
If applicable, fill in the issue number this pull request is fixing
Closes #1717
If applicable, provide an example illustrating new features this pull request is introducing
Comments
This is to make the interface somewhat consistent with
Solution
; there are some differences, e.g. round vs square brackets, or passing of lists vs argument lists, where fixes go beyond the scope of this PR. Also,Solution
currently does not slicegas["O2"].binary_diff_coeffs
correctly, so this PR merely ensures that implementations are mostly consistent.Checklist
scons build
&scons test
) and unit tests address code coverage