Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume relative paths in cantera.conf are relative to the source root #1750

Merged

Conversation

bryanwweber
Copy link
Member

@bryanwweber bryanwweber commented Aug 1, 2024

Changes proposed in this pull request

  • Assume that relative paths passed on the command line or in cantera.conf are relative to the source root. Don't change absolute paths.
  • I verified that this works locally on Windows and Linux. I also verified that absolute paths on Windows still work correctly.

If applicable, fill in the issue number this pull request is fixing

Closes #1743

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Assume that relative paths passed on the command line or in cantera.conf
are relative to the source root. Don't change absolute paths.
@bryanwweber bryanwweber self-assigned this Aug 1, 2024
@bryanwweber bryanwweber requested a review from a team August 1, 2024 14:09
@bryanwweber bryanwweber marked this pull request as ready for review August 1, 2024 14:09
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (f1b98ee) to head (573dbf1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
- Coverage   73.13%   73.12%   -0.01%     
==========================================
  Files         381      381              
  Lines       54134    54134              
  Branches     9222     9222              
==========================================
- Hits        39590    39587       -3     
- Misses      11587    11589       +2     
- Partials     2957     2958       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bryanwweber ... this all looks good to me!

@bryanwweber bryanwweber merged commit 886dfc1 into Cantera:main Aug 2, 2024
50 checks passed
@bryanwweber bryanwweber deleted the 1743-allow-relative-paths-cantera-conf branch August 2, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants