Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check for system SUNDIALS on Windows / alpha version bump #1755

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

speth
Copy link
Member

@speth speth commented Aug 3, 2024

Changes proposed in this pull request

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the compiling label Aug 3, 2024
@speth speth changed the title Fix version check for system SUNDIALS on Windows Fix version check for system SUNDIALS on Windows / alpha version bump Aug 3, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.13%. Comparing base (520267d) to head (ec32f7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1755   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files         381      381           
  Lines       54134    54134           
  Branches     9224     9224           
=======================================
  Hits        39590    39590           
  Misses      11587    11587           
  Partials     2957     2957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@ischoegl ischoegl merged commit bb3f51d into Cantera:main Aug 3, 2024
50 checks passed
@speth speth deleted the fix-system-sundials-win branch August 3, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants