Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sundials 6.0 and 6.1 #1774

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

bryanwweber
Copy link
Member

CVodeGetNumStepSolveFails is only defined in SUNDIALS 6.2 and up. Since the previous version check had a typo, this code was never included.

Closes #1771

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

CVodeGetNumStepSolveFails is only defined in SUNDIALS 6.2 and up. Since the previous version check had a typo, this code was never included.

Closes Cantera#1771
@bryanwweber bryanwweber requested a review from a team August 14, 2024 17:12
@bryanwweber bryanwweber self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (5393a88) to head (b97af88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   73.20%   73.19%   -0.01%     
==========================================
  Files         381      381              
  Lines       54289    54289              
  Branches     9242     9242              
==========================================
- Hits        39740    39737       -3     
- Misses      11577    11579       +2     
- Partials     2972     2973       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanwweber bryanwweber merged commit 9d28aa2 into Cantera:main Aug 14, 2024
50 checks passed
@bryanwweber bryanwweber deleted the 1771-support-sundials-6-61 branch August 14, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error with SUNDIALS 6.0 and 6.1
2 participants