[thermo] Improve solveCubic exception handling #1819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
writelog
messages forMixtureFugacity::solveCubic
to exception (no root found) and warning (merged roots) respectively.If applicable, fill in the issue number this pull request is fixing
Band-aid for #1699
The example from #1699 now fails with:
which allows for improved exception handling (rather than checking for invalid densities).
Checklist
scons build
&scons test
) and unit tests address code coverage