add integrator parameters to the InterfaceKinetics::advanceCoverages … #610
+144
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& ImplicitSurfChem constructor to allow users to modfiy
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 68.52% 68.53% +<.01%
==========================================
Files 363 363
Lines 39957 39978 +21
==========================================
+ Hits 27382 27400 +18
- Misses 12575 12578 +3
Continue to review full report at Codecov.
|
|
Yes, I think your first suggested test is a good one. For the tolerances, I agree that creating |
|
Not sure why the OSX TravisCI job timed out? |
|
@arghdos I restarted the job, let's see what happens |
speth
requested changes
Mar 14, 2019
skyreflectedinmirrors
force-pushed
the
add_interface_kinetics_integrator_options
branch
from
fe5e75f to
995a758
Compare
…hon interface, and test
skyreflectedinmirrors
force-pushed
the
add_interface_kinetics_integrator_options
branch
from
995a758 to
8634242
Compare
|
@speth -- updated this, should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…& ImplicitSurfChem constructor to allow users to modfiy
Please fill in the issue number this pull request is fixing:
Fixes #608
Changes proposed in this pull request:
@speth -- what would be a good test here? Something like simultaneously limiting the maximum step-size to
t_out/Nwhile limiting the maximum number of steps toN-1would be a good test from the cython interface for those values, but I'm not sure how to test that the rtol / atol or error test failures are correctly set without lowering the tests into C++? I guess I could add some information methods (similar to those in the base Integrator class) to query these directly, but that doesn't seem to fit well with the very short lived nature of the integrator inside of InterfaceKinetics...