Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make phase names consistent (CTI/XML vs YAML) #716

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Make phase names consistent (CTI/XML vs YAML) #716

merged 1 commit into from
Oct 24, 2019

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Oct 1, 2019 •
edited
Loading

Please fill in the issue number this pull request is fixing:

Fixes #715

Changes proposed in this pull request:

  • simple fix in SConstruct (use --id option in ck2yaml conversion)

speth
speth reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm just going to suggest waiting until we merge #696 so that we can avoid churn related to name change of the --id argument to --phase-id.

@ischoegl ischoegl force-pushed the consistent-phase-names branch from 877cd6f to fc18330 Compare October 23, 2019 19:03
@ischoegl
Copy link
Member Author

ischoegl commented Oct 23, 2019 •
edited
Loading

@speth ... the PR is rebased, and now uses the updated flag --name (instead of --id).

@ischoegl ischoegl requested a review from speth October 23, 2019 19:58
@speth speth merged commit 3b7eb0d into Cantera:master Oct 24, 2019
@ischoegl ischoegl deleted the consistent-phase-names branch December 16, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speth speth speth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changed phase names (CTI/XML vs. YAML)
2 participants
@ischoegl @speth