[PureFluid] Use pressure criteria to decide phase #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the pressure compared with the saturation pressure to decide gas or liquid phase, rather than temperature. This change is required because for some substances, the saturation temperature for low values of the pressure was outside the limits of the equation of state, resulting in convergence errors in the saturation solver. Since phaseOfMatter can throw, we need to translate exceptions in the Cython interface as well. Add tests to prevent regression with cases identifed in Cantera#786. Fixes Cantera#786.
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
- Coverage 71.45% 71.44% -0.01%
==========================================
Files 372 372
Lines 43522 43522
==========================================
- Hits 31098 31096 -2
- Misses 12424 12426 +2
Continue to review full report at Codecov.
|
speth
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the pressure compared with the saturation pressure to decide gas or
liquid phase, rather than temperature. This change is required because
for some substances, the saturation temperature for low values of the
pressure was outside the limits of the equation of state, resulting
in convergence errors in the saturation solver.
Since phaseOfMatter can throw, we need to translate exceptions in
the Cython interface as well.
Add tests to prevent regression with cases identifed in #786.
Fixes #786.
Checklist
scons build&scons test) and unit tests address code coverage