-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dualism of InterfaceKinetics vs Reactor Networks (ReactorSurface)? #61
Comments
I agree that there is a bit of redundancy here that would be nice to get rid of, but there are some differences between the two that need to be considered. First, the problem solved by Second, the pseudo-steady state solver available for the surface-only problem is quite different from anything we have available for the general reactor network. However, "different" may mostly mean broken in this case (see Cantera/cantera#609). |
@speth ... thanks for your response. It's been a while since I wrote this question, but the main point of my inquiry was that |
Conceptually, I can see how And yes, the pseudo-steady state solver would be useful if it worked reliably, but it doesn't seem to do that currently. I also wonder whether that solver could just be replaced by the one used for 1D problems. |
Yes - |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reopening based on recent discussion in #202. |
Cantera version
2.5.0a3
Expected Behavior
A single approach for solving surface problems in the context of zero-dimensional simulations.
Actual Behavior
There appear to be two distinct approaches to simulate surface kinetics problems.
InterfaceKinetics
Reactor
+ReactorSurface
object in a reactor networkadvance_coverages
vsadvance
).Proposal
It is conceivable to merge the approaches by introducing something along the lines of
Example 1:
diamond_cvd.py
Example 2:
surf_pfr.py
There are obviously other scenarios, e.g. edges / triple phase boundaries.
The steps to allow for this would require some changes of
ReactorBase
-derived classes, but would eliminate redundancies in the long run.An advantage of this approach would be that only one time integration approach needs to be maintained. Further, any future serialization would use the same framework.
The text was updated successfully, but these errors were encountered: