-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Reaction Rate Evaluators #87
Labels
work-in-progress
An enhancement that someone is currently working on
Comments
8 tasks
Merged
5 tasks
This was referenced Jun 15, 2021
5 tasks
5 tasks
This was referenced Oct 7, 2021
5 tasks
8 tasks
This was referenced Jan 31, 2022
This was referenced Feb 18, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Abstract
Following #63 (and based on comments in #79), a new framework for reaction factories and reaction rate evaluators (
MultiRateBase
) is now introduced with Cantera/cantera#982. Once fully implemented, the new framework will allow for a unified handling that avoids the rigidRate1
templates, and eliminates the need forFalloffFactory
, etc..Motivation
Describe the need for the work being done:
AnyMap
serialization)Description
An intermediate
Reaction3
class allows for a clean deprecation of reaction types that use the old framework; until the transition is complete (Cantera 3.0?), both will remain fully functional. The refactoring is planned to involve multiple phases:BulkKinetics
: use existingMultiBulkRates
rate evaluator to handle replacement classes, and deprecate current approachesa. PR to replace everything except
FalloffReaction
, i.e. createElementaryReaction3
,ThreeBodyReaction3
, ... see Refactor reaction rate evaluators cantera#995b. PR’s to update infrastructure … see Proof-of-concept: Modify reaction rates in memory cantera#1051 (modification of rate parameters in memory), Reaction rate factories cantera#1061 (rate factories), Make rate constant calculation consistent with Kee, et al. cantera#1084 (resolve role of
M
), Small fixes and improvements / sparse coefficient matrices cantera#1088 (remove some inconsistencies of API's)c. PR to replace
FalloffReactions
and associatedFalloff
andFalloffFactory
classes, i.e.LindemannFalloff
,TroeFalloff
,SRIFalloff
... see Wrap up GasKinetics cantera#1101InterfaceKinetics
: a newMultiInterfaceRates
rate evaluator will require some discussion prior to implementationa. PR to streamline ... see Preamble to InterfaceKinetics refactoring cantera#1184
b. Once everything is fully ported, deprecated classes (and associated handlers) can be removed and the
'3'
can be dropped from names of all replacement classes. ... see Refactor interface kinetics cantera#1181References
The following issues/PR's are tagged as there may be synergies and/or repercussions
modify_reaction
toInterfaceKinetics
InterfaceKinetics
and reactor networksThe text was updated successfully, but these errors were encountered: