Skip to content

Commit

Permalink
[influxdb] remove uint fields from InfluxDB plugins (open-telemetry#3…
Browse files Browse the repository at this point in the history
…3228)

**Description:** <Describe what has changed.>

This change removes the Metric signal `flags` field to/from InfluxDB
conversion. The InfluxDB field is type `uint` which is not supported in
InfluxDB v1 AND the Metric `flags` field is not particularly useful
(yet) in OpenTelemetry.

**Link to tracking Issue:** <Issue number if applicable>
Fixes open-telemetry#29896

**Testing:**
Material code changes and tests in
influxdata/influxdb-observability#305

**Documentation:** <Describe the documentation added.>
Small changes to docs in
influxdata/influxdb-observability#305
  • Loading branch information
jacobmarble authored May 27, 2024
1 parent 4fad287 commit 49b0d13
Show file tree
Hide file tree
Showing 11 changed files with 68 additions and 41 deletions.
27 changes: 27 additions & 0 deletions .chloggen/influxdbv1-flags.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: influxdb(exporter|receiver)

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: remove Metric flags field to/from InfluxDB conversion

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [29896]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
6 changes: 3 additions & 3 deletions cmd/configschema/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -454,9 +454,9 @@ require (
github.com/iancoleman/strcase v0.3.0 // indirect
github.com/imdario/mergo v0.3.16 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/influxdata/influxdb-observability/common v0.5.8 // indirect
github.com/influxdata/influxdb-observability/influx2otel v0.5.8 // indirect
github.com/influxdata/influxdb-observability/otel2influx v0.5.8 // indirect
github.com/influxdata/influxdb-observability/common v0.5.12 // indirect
github.com/influxdata/influxdb-observability/influx2otel v0.5.12 // indirect
github.com/influxdata/influxdb-observability/otel2influx v0.5.12 // indirect
github.com/influxdata/line-protocol/v2 v2.2.1 // indirect
github.com/ionos-cloud/sdk-go/v6 v6.1.11 // indirect
github.com/jackc/pgpassfile v1.0.0 // indirect
Expand Down
12 changes: 6 additions & 6 deletions cmd/configschema/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions cmd/otelcontribcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -528,9 +528,9 @@ require (
github.com/iancoleman/strcase v0.3.0 // indirect
github.com/imdario/mergo v0.3.16 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/influxdata/influxdb-observability/common v0.5.8 // indirect
github.com/influxdata/influxdb-observability/influx2otel v0.5.8 // indirect
github.com/influxdata/influxdb-observability/otel2influx v0.5.8 // indirect
github.com/influxdata/influxdb-observability/common v0.5.12 // indirect
github.com/influxdata/influxdb-observability/influx2otel v0.5.12 // indirect
github.com/influxdata/influxdb-observability/otel2influx v0.5.12 // indirect
github.com/influxdata/line-protocol/v2 v2.2.1 // indirect
github.com/ionos-cloud/sdk-go/v6 v6.1.11 // indirect
github.com/jackc/pgpassfile v1.0.0 // indirect
Expand Down
12 changes: 6 additions & 6 deletions cmd/otelcontribcol/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions exporter/influxdbexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ go 1.21.0

require (
github.com/cenkalti/backoff/v4 v4.3.0
github.com/influxdata/influxdb-observability/common v0.5.8
github.com/influxdata/influxdb-observability/otel2influx v0.5.8
github.com/influxdata/influxdb-observability/common v0.5.12
github.com/influxdata/influxdb-observability/otel2influx v0.5.12
github.com/influxdata/line-protocol/v2 v2.2.1
github.com/stretchr/testify v1.9.0
go.opentelemetry.io/collector/component v0.101.1-0.20240523155058-812210ba3685
Expand Down
8 changes: 4 additions & 4 deletions exporter/influxdbexporter/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -477,9 +477,9 @@ require (
github.com/iancoleman/strcase v0.3.0 // indirect
github.com/imdario/mergo v0.3.16 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/influxdata/influxdb-observability/common v0.5.8 // indirect
github.com/influxdata/influxdb-observability/influx2otel v0.5.8 // indirect
github.com/influxdata/influxdb-observability/otel2influx v0.5.8 // indirect
github.com/influxdata/influxdb-observability/common v0.5.12 // indirect
github.com/influxdata/influxdb-observability/influx2otel v0.5.12 // indirect
github.com/influxdata/influxdb-observability/otel2influx v0.5.12 // indirect
github.com/influxdata/line-protocol/v2 v2.2.1 // indirect
github.com/ionos-cloud/sdk-go/v6 v6.1.11 // indirect
github.com/jackc/pgpassfile v1.0.0 // indirect
Expand Down
12 changes: 6 additions & 6 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions receiver/influxdbreceiver/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ go 1.21.0

require (
github.com/influxdata/influxdb-client-go/v2 v2.13.0
github.com/influxdata/influxdb-observability/common v0.5.8
github.com/influxdata/influxdb-observability/influx2otel v0.5.8
github.com/influxdata/influxdb-observability/common v0.5.12
github.com/influxdata/influxdb-observability/influx2otel v0.5.12
github.com/influxdata/influxdb1-client v0.0.0-20220302092344-a9ab5670611c
github.com/influxdata/line-protocol/v2 v2.2.1
github.com/open-telemetry/opentelemetry-collector-contrib/internal/common v0.101.0
Expand Down
12 changes: 6 additions & 6 deletions receiver/influxdbreceiver/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 49b0d13

Please sign in to comment.