Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --incompatible_struct_has_no_methods for Bazel 8 preview #54

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Silic0nS0ldier
Copy link
Contributor

Flag is currently flipped in Bazel 8 preview releases. This change address the following issue affecting the repo rule yarn_install.

ERROR: An error occurred during the fetch of repository '____':
   Traceback (most recent call last):
	File "{output_base}/external/build_bazel_rules_nodejs/internal/npm_install/npm_install.bzl", line 919, column 24, in _yarn_install_impl
		_create_build_files(repository_ctx, "yarn_install", node, repository_ctx.attr.yarn_lock, repository_ctx.attr.generate_local_modules_build_files)
	File "{output_base}/external/build_bazel_rules_nodejs/internal/npm_install/npm_install.bzl", line 457, column 6, in _create_build_files
		).to_json()
Error: 'struct' value has no field or method 'to_json'

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Silic0nS0ldier Silic0nS0ldier requested a review from fa93hws June 28, 2024 02:26
Copy link
Contributor

@lamcw lamcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silic0nS0ldier Silic0nS0ldier removed the request for review from fa93hws July 1, 2024 23:54
@Silic0nS0ldier Silic0nS0ldier merged commit 954a6b5 into main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants